-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix eslint and ts errors in dev and introduce tsconfig.prod.ts file #74
Closed
mkarajohn
wants to merge
2
commits into
master
from
10-09-chore_fix_eslint_and_ts_errors_in_dev_and_introduce_tsconfig.prod.ts_file
Closed
chore: fix eslint and ts errors in dev and introduce tsconfig.prod.ts file #74
mkarajohn
wants to merge
2
commits into
master
from
10-09-chore_fix_eslint_and_ts_errors_in_dev_and_introduce_tsconfig.prod.ts_file
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarajohn
force-pushed
the
10-09-chore_fix_eslint_and_ts_errors_in_dev_and_introduce_tsconfig.prod.ts_file
branch
from
October 10, 2023 11:57
dcbf28b
to
988fc42
Compare
This was referenced Oct 10, 2023
mkarajohn
force-pushed
the
10-09-chore_fix_eslint_and_ts_errors_in_dev_and_introduce_tsconfig.prod.ts_file
branch
from
October 16, 2023 23:37
988fc42
to
3754372
Compare
This was referenced Oct 16, 2023
panvourtsis
reviewed
Oct 19, 2023
panvourtsis
previously approved these changes
Oct 19, 2023
This was referenced Oct 19, 2023
This was referenced Oct 22, 2023
panvourtsis
dismissed
their stale review
October 23, 2023 10:33
i am pulling my approval as this will be the point to fix any tests
mkarajohn
force-pushed
the
10-09-chore_fix_eslint_and_ts_errors_in_dev_and_introduce_tsconfig.prod.ts_file
branch
from
October 24, 2023 12:54
7bf9dde
to
bf89cd4
Compare
mkarajohn
force-pushed
the
10-09-chore_fix_eslint_and_ts_errors_in_dev_and_introduce_tsconfig.prod.ts_file
branch
from
October 24, 2023 14:16
bf89cd4
to
3754372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DSTRBTN-540
Generated summary (powered by Graphite)